Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed version names #376

Merged
merged 2 commits into from
Aug 28, 2023
Merged

Fixed version names #376

merged 2 commits into from
Aug 28, 2023

Conversation

gsoares85
Copy link
Collaborator

No description provided.

@@ -5,7 +5,7 @@ pragma solidity ^0.8.0;
import "../zeppelin/math/SafeMath.sol";
import "../zeppelin/ownership/Ownable.sol";

contract AllowTokensV0 is Ownable {
contract AllowTokensOld is Ownable {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe worth to use numbers rather then aliases in names ?(in terms of consistency and versioning?)

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
6.2% 6.2% Duplication

@MaximStanciu8 MaximStanciu8 merged commit 4be4e61 into master Aug 28, 2023
@MaximStanciu8 MaximStanciu8 deleted the feature/GBI-1386-VULN-417 branch August 28, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants