Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GBI 540: Federator Remove functionality related to binance #337

Merged
merged 2 commits into from
May 16, 2022
Merged

GBI 540: Federator Remove functionality related to binance #337

merged 2 commits into from
May 16, 2022

Conversation

joaoiovlabs
Copy link
Contributor

Title of pull request

GBI 540: Federator Remove functionality related to binance

Description

  • Remove bscscan.key from .gitignore
  • Remove all references of Binance from bridge/hardhat.config.js
  • Remove all references of Binance from bridge/hardhat/helper/tokens.js
  • Delete file bridge/deploy/upgrades/03_create_sideTokens_bsc.js
  • Delete file federator/config/bsctestnet.json
  • Remove all references of Binance from bridge/hardhat/script/createTokensERC20Rsk.js
  • Remove bsctestnet from federator/config/config.sample.js

gsoares85
gsoares85 previously approved these changes May 3, 2022
View reviewed changes
aguschirico
aguschirico previously approved these changes May 4, 2022
View reviewed changes
Copy link
Contributor

@aguschirico aguschirico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
DO NOT MERGE YET, we will test thoroughly on local first.

@joaoiovlabs
Merge branch 'master' of github.com:rsksmart/tokenbridge into GBI_540…
10a0b57 
…_Federator_Remove_functionality_related_to_binance
@joaoiovlabs joaoiovlabs dismissed stale reviews from aguschirico and gsoares85 via 10a0b57 May 16, 2022 12:36
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
100.0% 100.0% Duplication

@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.862% when pulling 10a0b57 on GBI_540_Federator_Remove_functionality_related_to_binance into d899c77 on master.

poldo-iov
poldo-iov approved these changes May 16, 2022
View reviewed changes
Copy link

@poldo-iov poldo-iov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aguschirico aguschirico merged commit c79fcd8 into master May 16, 2022
@aguschirico aguschirico deleted the GBI_540_Federator_Remove_functionality_related_to_binance branch May 16, 2022 17:37
Dominikkq pushed a commit to Dominikkq/tokenbridge that referenced this pull request Jan 19, 2025
@augustoIOV
Merge pull request rsksmart#337 from rsksmart/GBI_540_Federator_Remov…
0f7f92e 
…e_functionality_related_to_binance

GBI 540: Federator Remove functionality related to binance
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poldo-iov poldo-iov poldo-iov approved these changes

@aguschirico aguschirico aguschirico left review comments

@gsoares85 gsoares85 gsoares85 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@joaoiovlabs @coveralls @gsoares85 @aguschirico @poldo-iov