Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt at fixing Federator memory leak #238

Merged
merged 2 commits into from
Aug 10, 2021
Merged

Conversation

marcciosilva
Copy link
Contributor

@marcciosilva marcciosilva commented Aug 4, 2021

  • Avoid constant creation of new web3.eth.Contract objects (related to this issue)
  • Replace var with let/const where appropriate to avoid scope related memory leaks

Marccio Silva added 2 commits August 4, 2021 17:47
…ap class variable) to avoid web3.eth.Contract memory leak issue (web3/web3.js#3042), replace var with let/const where appropriate
…y one address per ABI, made no sense to have a multi level map)
Copy link
Contributor

@pmprete pmprete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Work! 💯

@pmprete pmprete merged commit 591403c into master Aug 10, 2021
@pmprete pmprete deleted the fix/federator-memory-leak branch August 10, 2021 17:53
Dominikkq pushed a commit to Dominikkq/tokenbridge that referenced this pull request Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants