Adds 'should create multiple pegouts with mixed values same and above… #163
Conversation
| const txPromise = rskTxHelper.sendTransaction({ | ||
| from: rskFromAddress, | ||
| to: BRIDGE_ADDRESS, | ||
| value: amountInWeisBN, | ||
| gasPrice: TO_BRIDGE_GAS_PRICE, | ||
| }); | ||
|
|
||
| if(!mine) { |
There was a problem hiding this comment.
nit:
| if(!mine) { | |
| if (!mine) { |
There was a problem hiding this comment.
I just noticed there is a mixed of if ( an if( in the test. I always prefer if(. But what should we always use? @nathanieliov , @marcos-iov , @julia-zack .
|
|
||
| await triggerRelease(rskTxHelpers, btcTxHelper, callbacks); | ||
|
|
||
| // Checking all the pegout events are emitted and in order |
There was a problem hiding this comment.
It seems they all get mined in the same block. How are we verifying the order?
There was a problem hiding this comment.
They all get mined in the same block, otherwise, the test would fail.
Since they can get mined in different order, I'm forced to use pegoutsEvents.find index of indices and getAddressUtxo to find the corresponding utxos.
| const txPromise = rskTxHelper.sendTransaction({ | ||
| from: rskFromAddress, | ||
| to: BRIDGE_ADDRESS, | ||
| value: amountInWeisBN, | ||
| gasPrice: TO_BRIDGE_GAS_PRICE, | ||
| }); | ||
|
|
||
| if(!mine) { |
jeremy-then
force-pushed
the
add-multiple-pegouts-batch-test
branch
from
2ac0319
to
5c567a3
Compare
marcos-iov
force-pushed
the
add-pegout-request-from-contract-test
branch
from
9c1d2e2
to
253411e
Compare
… minimum' test Rebase
jeremy-then
force-pushed
the
add-multiple-pegouts-batch-test
branch
from
5c567a3
to
bc9cb09
Compare
|
| const pegoutCreatedCallback = async () => { | ||
| bridgeStateAfterPegoutCreation = await getBridgeState(rskTxHelper.getClient()); | ||
| }; |
There was a problem hiding this comment.
I might be missing something, what's the value of this callback? It will simply get the Bridge state and do nothing with it
| const pegoutTransaction2 = await pegoutTransaction2Promise; | ||
| const pegoutTransaction3 = await pegoutTransaction3Promise; | ||
|
|
||
| // Assert |
There was a problem hiding this comment.
Should we check the Bridge state at this point? To assert there are 3 pegout requests created
Adds 'should create multiple pegouts with mixed values same and above minimum' test