Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PP-753: Implement coingecko pricer #81

Merged
merged 5 commits into from
Mar 24, 2023
Merged

PP-753: Implement coingecko pricer #81

merged 5 commits into from
Mar 24, 2023

Conversation

antomor
Copy link
Collaborator

@antomor antomor commented Mar 22, 2023 •
edited
Loading

What

  • Implement Coingecko client to retrieve RBTC price

Why

  • Coinbase client doesn't support RBTC any more

@antomor antomor marked this pull request as ready for review March 23, 2023 17:54
franciscotobar
franciscotobar approved these changes Mar 23, 2023
View reviewed changes
Copy link
Collaborator

@franciscotobar franciscotobar left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, my only concern is about the recovery from errors.

@antomor antomor merged commit 5a500be into main Mar 24, 2023
@antomor antomor deleted the PP-753/replace-coinbase-pricer-with-coingecko branch March 24, 2023 10:08
@antomor antomor mentioned this pull request Mar 24, 2023
Merged
@antomor antomor self-assigned this Mar 24, 2023
@antomor antomor added the bug Something isn't working label Mar 24, 2023
@antomor antomor mentioned this pull request Mar 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franciscotobar franciscotobar franciscotobar approved these changes

Assignees

@antomor antomor

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antomor @franciscotobar