Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PP-570/pricer-case-sensitive #43

Merged
merged 2 commits into from
Nov 14, 2022
Merged

PP-570/pricer-case-sensitive #43

merged 2 commits into from
Nov 14, 2022

Conversation

franciscotobar
Copy link
Collaborator

@franciscotobar franciscotobar commented Nov 10, 2022 •
edited
Loading

What

  • The relayPricer and API needs to handle case sensitive Currencies and Tokens.
  • Typing to guarantee the appropriate name.

Why

  • There are different type of casing for tokens and currencies and we need to be able to let the programmer know that the name that is using is valid.

Refs

  • (PP-570)[https://rsklabs.atlassian.net/browse/PP-570]

@franciscotobar franciscotobar requested a review from a team November 10, 2022 17:36
ironFe93
ironFe93 approved these changes Nov 11, 2022
View reviewed changes
Copy link
Contributor

@ironFe93 ironFe93 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would try to avoid the 'as FromCurrency' in ExchangeApi.ts, but I'm probably being nitpicky. LGTM.

@franciscotobar
Copy link
Collaborator Author

you are right, I tried to avoid it several times but I need an opinion about it, maybe we can discuss it but if you see the history, I did a commit without forcing the typing but I change it.

antomor
antomor approved these changes Nov 14, 2022
View reviewed changes
Copy link
Collaborator

@antomor antomor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antomor antomor merged commit a9c6544 into master Nov 14, 2022
@antomor antomor deleted the PP-570/pricer-case-sensitive branch November 14, 2022 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ironFe93 ironFe93 ironFe93 approved these changes

@antomor antomor antomor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@franciscotobar @antomor @ironFe93