Skip to content

Commit

Permalink
Do not filter out Image.source prop when sending it C++ on New Archit…
Browse files Browse the repository at this point in the history
…ecture on Android

Summary:
## Changelog:
[Internal] -

This fixes a subtle problem whereas an update to `Image.source` (or `Image.src`) prop on JS side may not end up getting propagated to the C++ side, with New Architecture.

As the result, this can lead to some weird corner cases, whereas e.g. layout doesn't update after the image's size changes.

Differential Revision: D51479305
  • Loading branch information
rshest authored and facebook-github-bot committed Nov 20, 2023
1 parent b4d4aef commit ed02ff9
Showing 1 changed file with 5 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,11 @@ export const __INTERNAL_VIEW_CONFIG: PartialViewConfig =
borderTopLeftRadius: true,
resizeMethod: true,
src: true,
// NOTE: New Architecture expects this to be called `source`,
// regardless of the platform, therefore propagate it as well.
// For the backwards compatibility reasons, we keep both `src`
// and `source`, which will be identical at this stage.
source: true,
borderRadius: true,
headers: true,
shouldNotifyLoadEvents: true,
Expand Down

0 comments on commit ed02ff9

Please sign in to comment.