Skip to content

Commit

Permalink
Add missing invalidate() to setOverflow() (facebook#45835)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: facebook#45835

`ReactViewBackgroundManager` will do this for us (and otherwise doesn't do anything draw related), but this will be removed when BackgroundStyleApplicator is rolled out, and not all callers use `ReactViewBackgroundManager`.

Changelog:
[Android][Fixed]

Reviewed By: philIip

Differential Revision: D60489756

fbshipit-source-id: 37cfc2b90af057bc142ad95b93e32941edb17ca5
  • Loading branch information
NickGerleman authored and facebook-github-bot committed Aug 1, 2024
1 parent 7047b7e commit 087193c
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -284,6 +284,7 @@ public void flashScrollIndicators() {
public void setOverflow(@Nullable String overflow) {
mOverflow = overflow == null ? Overflow.SCROLL : Overflow.fromString(overflow);
mReactBackgroundManager.setOverflow(overflow == null ? ViewProps.SCROLL : overflow);
invalidate();
}

public void setMaintainVisibleContentPosition(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -272,6 +272,7 @@ public void flashScrollIndicators() {
public void setOverflow(@Nullable String overflow) {
mOverflow = overflow == null ? Overflow.SCROLL : Overflow.fromString(overflow);
mReactBackgroundManager.setOverflow(overflow == null ? ViewProps.SCROLL : overflow);
invalidate();
}

public void setMaintainVisibleContentPosition(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -792,5 +792,6 @@ private void applyTextAttributes() {
public void setOverflow(@Nullable String overflow) {
mOverflow = overflow == null ? Overflow.VISIBLE : Overflow.fromString(overflow);
mReactBackgroundManager.setOverflow(overflow);
invalidate();
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -1294,6 +1294,7 @@ void setEventDispatcher(@Nullable EventDispatcher eventDispatcher) {
public void setOverflow(@Nullable String overflow) {
mOverflow = overflow == null ? Overflow.VISIBLE : Overflow.fromString(overflow);
mReactBackgroundManager.setOverflow(overflow);
invalidate();
}

@Override
Expand Down

0 comments on commit 087193c

Please sign in to comment.