Skip to content

Commit

Permalink
[INFRA] Illegal dependency fix (elastic#199395)
Browse files Browse the repository at this point in the history
## Summary

This PR makes the `vis-type-timeseries-plugin` a shared component fixing
the dependency error for infra plugin.

I removed the infra folder from the exceptions list because it was
preventing the linter from acknowledging the fix.
  • Loading branch information
bryce-b authored Nov 12, 2024
1 parent bfbeb14 commit 8a8363f
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 4 deletions.
3 changes: 0 additions & 3 deletions .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -1995,9 +1995,6 @@ module.exports = {
// logsShared depends on o11y/private plugins, but platform plugins depend on it
'x-pack/plugins/observability_solution/logs_shared/**',

// this plugin depends on visTypeTimeseries plugin (for TSVB viz) which is platform/private ATM
'x-pack/plugins/observability_solution/infra/**',

// TODO @kibana/operations
'scripts/create_observability_rules.js', // is importing "@kbn/observability-alerting-test-data" (observability/private)
'src/cli_setup/**', // is importing "@kbn/interactive-setup-plugin" (platform/private)
Expand Down
2 changes: 1 addition & 1 deletion src/plugins/vis_types/timeseries/kibana.jsonc
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"@elastic/kibana-visualizations"
],
"group": "platform",
"visibility": "private",
"visibility": "shared",
"description": "Registers the TSVB visualization. TSVB has its one editor, works with index patterns and index strings and contains 6 types of charts: timeseries, topN, table. markdown, metric and gauge.",
"plugin": {
"id": "visTypeTimeseries",
Expand Down

0 comments on commit 8a8363f

Please sign in to comment.