ci-tests are now a requirement of the release workflow (kube-burner#515)

* ci-tests are now a requirement of the release workflow Signed-off-by: Raul Sevilla <[email protected]> * Remove lint requirements from build Signed-off-by: Raul Sevilla <[email protected]> --------- Signed-off-by: Raul Sevilla <[email protected]>
rsevilla87 · Nov 28, 2023 · 142e646 · 142e646
1 parent b4bb05d
commit 142e646
Show file tree

Hide file tree

Showing 8 changed files with 36 additions and 27 deletions.
diff --git a/.github/workflows/builders.yml b/.github/workflows/builders.yml
@@ -1,4 +1,3 @@
-# builders.yml
 name: Build Binary and Images
 on:
   workflow_call:
@@ -7,7 +6,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
 
-    - uses: actions/checkout@v3
+    - uses: actions/checkout@v4
       with:
         fetch-depth: 1
         ref: ${{ github.event.pull_request.head.sha }}

diff --git a/.github/workflows/ci-tests.yml b/.github/workflows/ci-tests.yml
@@ -0,0 +1,19 @@
+name: CI tests
+on:
+  workflow_call:
+  pull_request_target:
+    branches:
+      - master
+      - main
+
+jobs:
+  lint:
+    uses: ./.github/workflows/linters.yml
+
+  build:
+    uses: ./.github/workflows/builders.yml
+
+  tests:
+    needs: build
+    uses: ./.github/workflows/test-k8s.yml
+    secrets: inherit
diff --git a/.github/workflows/docs.yml b/.github/workflows/docs.yml
@@ -6,7 +6,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Check out code
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         with:
           fetch-depth: 0
 

diff --git a/.github/workflows/gorelease.yml b/.github/workflows/gorelease.yml
@@ -8,7 +8,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Check out code into the Go module directory
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         with:
           fetch-depth: 0 # See: https://goreleaser.com/ci/actions/
           persist-credentials: false

diff --git a/.github/workflows/image-upload.yml b/.github/workflows/image-upload.yml
@@ -29,7 +29,7 @@ jobs:
           go-version: 1.19
 
       - name: Check out code
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         with:
           fetch-depth: 0
           persist-credentials: false
@@ -64,7 +64,7 @@ jobs:
     steps:
 
       - name: Check out code
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         with:
           fetch-depth: 1
           persist-credentials: false

diff --git a/.github/workflows/pullrequest.yml → .github/workflows/linters.yml b/.github/workflows/pullrequest.yml → .github/workflows/linters.yml
@@ -1,21 +1,13 @@
-# pullrequest.yml
-name: Pull Request Workflow
+name: Linters
 on:
-  push:
-    branches:
-      - master
-  pull_request_target:
-    branches:
-      - master
-      - main
-
+  workflow_call:
 jobs:
   linters:
     runs-on: ubuntu-latest
     steps:
 
     - name: Check out code
-      uses: actions/checkout@v3
+      uses: actions/checkout@v4
       with:
         fetch-depth: 1
         ref: ${{ github.event.pull_request.head.sha }}
@@ -26,11 +18,3 @@ jobs:
 
     - name: Run pre-commit hooks
       run: pre-commit run --all-files
-
-  build:
-    uses: ./.github/workflows/builders.yml
-    needs: linters
-  tests:
-    needs: build
-    uses: ./.github/workflows/test-k8s.yml
-    secrets: inherit
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -4,12 +4,19 @@ on:
     tags:
       - "*" # triggers only if push new tag version
 jobs:
+  ci-tests:
+    uses: ./.github/workflows/ci-tests.yml
+    secrets: inherit
+
   release-build:
     uses: ./.github/workflows/gorelease.yml
+    needs: ci-tests
 
   image-upload:
     uses: ./.github/workflows/image-upload.yml
+    needs: ci-tests
     secrets: inherit
 
   deploy-docs:
     uses: ./.github/workflows/docs.yml
+    needs: ci-tests
diff --git a/.github/workflows/test-k8s.yml b/.github/workflows/test-k8s.yml
@@ -21,7 +21,7 @@ jobs:
     steps:
 
     - name: Check out code
-      uses: actions/checkout@v3
+      uses: actions/checkout@v4
       with:
         fetch-depth: 1
         ref: ${{ github.event.pull_request.head.sha }}
@@ -56,7 +56,7 @@ jobs:
     steps:
 
     - name: Check out code
-      uses: actions/checkout@v3
+      uses: actions/checkout@v4
       with:
         fetch-depth: 1
         ref: ${{ github.event.pull_request.head.sha }}