Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: display error stack when using .Fields() #560

Merged
merged 3 commits into from
Oct 4, 2023
Merged

feat: display error stack when using .Fields() #560

merged 3 commits into from
Oct 4, 2023

Conversation

julienrbrt
Copy link
Contributor

@julienrbrt julienrbrt commented Jul 4, 2023

Display error stack when using .Fields(). Right now, even if the ErrorStackMarshaler is set, the stack will not be displayed if there is an error in the Fields() values but only when using Err().

@julienrbrt
Copy link
Contributor Author

Gentle bump @rs. Is that something that could be added?

@rs rs merged commit ed609e7 into rs:master Oct 4, 2023
madkins23 pushed a commit to madkins23/zerolog that referenced this pull request Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants