Returns nilID when id is invalid (#88)

rs · Oct 9, 2022 · 1a49bc0 · 1a49bc0
1 parent 7fac693
commit 1a49bc0
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/id.go b/id.go
@@ -239,6 +239,7 @@ func (id *ID) UnmarshalText(text []byte) error {
 		}
 	}
 	if !decode(id, text) {
+		*id = nilID
 		return ErrInvalidID
 	}
 	return nil

diff --git a/id_test.go b/id_test.go
@@ -131,6 +131,10 @@ func TestFromStringInvalid(t *testing.T) {
 	if err != ErrInvalidID {
 		t.Errorf("FromString(invalid) err=%v, want %v", err, ErrInvalidID)
 	}
+	id, err := FromString("c6e52g2mrqcjl44hf179")
+	if id != nilID {
+		t.Errorf("FromString() =%v, want %v", id, nilID)
+	}
 }
 
 type jsonType struct {