-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add mutation lost in slimDOMOptions #994
fix: add mutation lost in slimDOMOptions #994
Conversation
when using Comment width a when you but in |
in [email protected], mirror.getId() return -1 may caused by:
considering case 2: |
before: before.movafter fixed: after.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your very nice pull request. The description and solution are very clear and clean.
The failure of Format Check CI can be ignored because it may be caused by the old branch base. I've checked the snapshot.ts and there's no formatting issue.
@Mark-Fenng @Yuyz0112 |
Nope, I think everything is good. Just waiting for @Yuyz0112's review. |
sorry for the late |
fix: #993