Fix <use> to use local resource instead of absolute path #938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously when
<svg>s were snapshotted,<use>tag href was serialized to absolute path. But one's that start with '#' should be a local resource and should not be serialized to absolute path and instead left as is.Previously:
<use href="https://google.com/#resource-a"></use>Which would not resolve the correct local resource.
Now:
<use href="#resource-a"></use>Which correctly resolves the local svg resource. It looks like the
xlink:hrefcase is already handled (but that attribute is deprecated in newsvgspec)See: https://developer.mozilla.org/en-US/docs/Web/SVG/Element/use