fix(rrweb-snapshot): don't exclude @import CSS rules from the output when an exception is thrown #720
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not exclude @import CSS rules from the output when an exception is thrown and use
CSSRule.cssText
instead.rrweb-snapshot throws a
SecurityError
exception when parses@import
CSS rules, that point out to an external domain and are declared within a CSS file.page.html:
styles.css:
The fix is meant to fix this problem and keep the original CSS line if another issue happens while serializing an
@import
CSS rule.A repository with an example of the issue: https://github.com/hvpavel/rrweb-snapshot-css-import-issue.