fix: Handle exceptions thrown from postcss when calling adaptCssForReplay #1580
+30
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 27f01fe The changes in this PR will be included in the next version bump. This PR includes changesets to release 19 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
heads up, i think the root cause is #1575 |
|
@otan Good call out! That definitely seems like one of the ways invalid CSS can be passed to For this particular PR, I just wanted to simply make sure exceptions from |
Vadman97
added a commit
to highlight/highlight
that referenced
this pull request
Oct 10, 2024
## Summary Bring back postcss css parsing which offers better reliability with inlined stylesheets and better performance. Fixes replay of a session where the existing CSS parsing of rrweb was broken. Incorporates rrweb-io/rrweb#1580 to fix broken replays due to postcss crash. ## How did you test this change? https://preview.highlight.io/102751/sessions/35zPFX0OPXs166n5L7m1GEZaqWgL?%7Er_preview=%7B%22action%22%3A%22start%22%2C%22mode%22%3A%22production%22%2C%22region%22%3A%22ewr%22%2C%22variantId%22%3A%2201J8GFGDTWBWCRZZZ7G92P9HJX%22%2C%22variantData%22%3A%22%7B%5C%22type%5C%22%3A%5C%22branch%5C%22%2C%5C%22branch%5C%22%3A%5C%22vadim%2Fsession-troubleshooting%5C%22%2C%5C%22githubOwnerName%5C%22%3A%5C%22highlight%5C%22%2C%5C%22githubRepositoryName%5C%22%3A%5C%22highlight%5C%22%7D%22%7D fixes replay that is otherwise broken https://preview.highlight.io/14083/sessions/77X2eTJA5TIbEydiUytAFmZhJoXn?commentId=90302&commentId=90302&commentId=90302&commentId=90302&commentId=90302&commentId=90302&commentId=90302&commentId=90302&commentId=90302&commentId=90302&commentId=90302&commentId=90302&commentId=90302&commentId=90302&commentId=90302&commentId=90302&commentId=90302&commentId=90302&commentId=90302&commentId=90302&commentId=90302&commentId=90302&commentId=90302&commentId=90302&commentId=90302&commentId=90302&commentId=90302&commentId=90302&commentId=90302&page=1&query=viewed_by_anyone%3Dtrue+visited-url%3D%22*6532da*%22&commentId=90302&commentId=90302&%7Er_preview=%7B%22action%22%3A%22start%22%2C%22mode%22%3A%22production%22%2C%22region%22%3A%22ewr%22%2C%22variantId%22%3A%2201J8GFGDTWBWCRZZZ7G92P9HJX%22%2C%22variantData%22%3A%22%7B%5C%22type%5C%22%3A%5C%22branch%5C%22%2C%5C%22branch%5C%22%3A%5C%22vadim%2Fsession-troubleshooting%5C%22%2C%5C%22githubOwnerName%5C%22%3A%5C%22highlight%5C%22%2C%5C%22githubRepositoryName%5C%22%3A%5C%22highlight%5C%22%7D%22%7D ## Are there any deployment considerations? frontend only continues to work  ## Does this work require review from our design team? no
guntherjh
force-pushed
the
jg-app-handle-postcss-exceptions
branch
from
a08c325
to
ae97dac
Compare
daibhin
approved these changes
Oct 15, 2024
guntherjh
added a commit
to pendo-io/rrweb
that referenced
this pull request
Oct 21, 2024
- Apply formatting changes - Remove import of postcss in test file Upstream PR: rrweb-io#1580
guntherjh
force-pushed
the
jg-app-handle-postcss-exceptions
branch
from
ae97dac
to
c1accef
Compare
- Apply formatting changes - Remove import of postcss in test file
guntherjh
force-pushed
the
jg-app-handle-postcss-exceptions
branch
from
c1accef
to
27f01fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
try/catcharoundpostcss().process()so that exceptions won't cause playback to crash. I was encountering issues where invalid CSS was being passed topostcsswhich would result in CssSyntaxError. I am still investigating why invalid CSS is passed to adaptCssForReplay in the first place, but for now this change should at least make sure any exceptions frompostcssare at least handled and logged. I am currently usingwarnto log the exceptions but am happy to switch that to something else if need be.Related discussion in rrweb slack: https://rrweb.slack.com/archives/C01BYDC5C93/p1727975312250899