-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Include takeFullSnapshot function in rrweb #1527
Conversation
🦋 Changeset detectedLatest commit: 3ac0ad7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 18 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Hi @arredgroup, thanks for the contribution. After reading your description I'm still not sure I fully understand the use case. Could you elaborate a bit on this topic? Also maybe this is a better fit for @rrweb/record instead of rrweb itself, but that depends on the use case I guess. |
Sure, we are using rrweb, but in some specific paths, for data security we need to pause the recording and continue, to do that, we decide to stop the emit event, with a return before data is enqueued, but we need to take a full snapshot to refresh the screen recording when pause is finished. the idea is use this method to avoid stop the recording and start other. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with exporting this function explicitly. This function is defined similarly to addCustomEvent
and freezePage
, both of which were exported long ago. Therefore, it makes sense to also export takeFullSnapshot.
Anything exported in |
* export takeFullSnapshot function in rrweb
* export takeFullSnapshot function in rrweb
* export takeFullSnapshot function in rrweb
Added takeFullSnapshot function to allow retake a snapshot if user decide pause recording (avoid emit function) and after resume with an updated screen