-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix maskInputFn is ignored during the creation of the full snapshot #1386
Fix maskInputFn is ignored during the creation of the full snapshot #1386
Conversation
🦋 Changeset detectedLatest commit: c44b56c The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@ababik I saw the tests are failing. Any plans to fix them? I'm happy to help. |
@Juice10 was this just a copy/paste error on your part do you recall? (referring to https://github.com/rrweb-io/rrweb-snapshot/pull/83/files#diff-0151af937db3d4d81e0883cfa20e4370c007c43b72afeb1e55a9058b4276df37R36 ) |
For some context:
At that point rrweb-snapshot was a separate repository. The default versions of these two functions are slightly different in that the |
prettier was complaining about the trailing space
Any updates on this one? It looks like it's pretty much good to go? |
…rweb-io#1386) Fix that the optional `maskInputFn` was being accidentally ignored during the creation of the full snapshot
…rweb-io#1386) Fix that the optional `maskInputFn` was being accidentally ignored during the creation of the full snapshot
…rweb-io#1386) Fix that the optional `maskInputFn` was being accidentally ignored during the creation of the full snapshot
Fix for #1385