Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: inlineImages and image is cors,the image tag is broken #1359

Closed
wants to merge 1 commit into from

Conversation

xujiujiu
Copy link
Contributor

Copy link

changeset-bot bot commented Nov 27, 2023

⚠️ No Changeset found

Latest commit: e859c12

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Juice10
Copy link
Contributor

Juice10 commented Dec 1, 2023

Thanks for creating this fix @xujiujiu, we're going to be replacing all of the existing code for inlineImages with #1239. So I'm closing this PR for that reason.

We might use your code as a fallback in the case where fetch isn't allowed due to security settings. Thanks again for taking the time to debug and come up with a fix for our current situation

@Juice10 Juice10 closed this Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants