Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Asset event type and capture assets #1239

Open
wants to merge 86 commits into
base: master
Choose a base branch
from
Open

Add Asset event type and capture assets #1239

wants to merge 86 commits into from

Commits on Jun 26, 2024

  1. Add Asset event type and capture assets

    @Juice10
    Juice10 committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    525553e View commit details
    Browse the repository at this point in the history

  2. Add test to prove player works

    @Juice10
    Juice10 committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    7c8cb42 View commit details
    Browse the repository at this point in the history

  3. Rename assetCaptureConfig to assetCapture

    @Juice10
    Juice10 committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    7e7236c View commit details
    Browse the repository at this point in the history

  4. Document assetCapture config

    @Juice10
    Juice10 committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    e7d1b4f View commit details
    Browse the repository at this point in the history

  5. Create asset event for assets that failed to load

    @Juice10
    Juice10 committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    ca7598a View commit details
    Browse the repository at this point in the history

  6. Move types from rrweb-snapshot to @rrweb/types

    @Juice10
    Juice10 committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    da0f676 View commit details
    Browse the repository at this point in the history

  7. WIP asset manager for replay

    @Juice10
    Juice10 committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    c1346dd View commit details
    Browse the repository at this point in the history

  8. Add placeholder tests

    @Juice10
    Juice10 committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    e22761d View commit details
    Browse the repository at this point in the history

  9. Fix image source attribute in rebuild function

    @Juice10
    Juice10 committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    b39560b View commit details
    Browse the repository at this point in the history

  10. Update path in tsconfig.json

    @Juice10
    Juice10 committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    8009004 View commit details
    Browse the repository at this point in the history

  11. Fix asset loading in Replayer

    @Juice10
    Juice10 committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    8c30174 View commit details
    Browse the repository at this point in the history

  12. Add todo tests

    @Juice10
    Juice10 committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    a6e04f7 View commit details
    Browse the repository at this point in the history

  13. Add asset mutation events for replayer test

    @Juice10
    Juice10 committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    227646e View commit details
    Browse the repository at this point in the history

  14. Add replay for cached asset on attribute changes

    @Juice10
    Juice10 committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    ed80d92 View commit details
    Browse the repository at this point in the history

  15. Fix syntax error

    @Juice10
    Juice10 committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    b0c9db4 View commit details
    Browse the repository at this point in the history

  16. Move assetCapture params to @rrweb/types and add them to meta events

    @Juice10
    Juice10 committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    74a1283 View commit details
    Browse the repository at this point in the history

  17. Add asset capture config to meta events

    @Juice10
    Juice10 committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    1c3517c View commit details
    Browse the repository at this point in the history

  18. NodeType was moved to @rrweb/types

    @Juice10
    Juice10 committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    acb6aae View commit details
    Browse the repository at this point in the history

  19. Upgrade jest and rollup in rrweb-snapshot

    @Juice10
    Juice10 committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    62caee4 View commit details
    Browse the repository at this point in the history

  20. Update snapshots to include assetCapture settings

    @Juice10
    Juice10 committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    39e06a7 View commit details
    Browse the repository at this point in the history

  21. Mark inlineImages as deprecated in favor of assetCapture

    @Juice10
    Juice10 committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    a3199af View commit details
    Browse the repository at this point in the history

  22. Fix rrdom build

    @Juice10
    Juice10 committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    b9ad572 View commit details
    Browse the repository at this point in the history

  23. Fix deprecated test

    @Juice10
    Juice10 committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    333fa0b View commit details
    Browse the repository at this point in the history

  24. Rename assetCapture to captureAssets 

    Also deprecate a couple inlineImages tests
    @Juice10
    Juice10 committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    1040328 View commit details
    Browse the repository at this point in the history

  25. Remove console.log statements from AssetManager 

    class
    @Juice10
    Juice10 committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    b7ab065 View commit details
    Browse the repository at this point in the history

  26. Rename assetCapture to captureAssets in rrweb test

    @Juice10
    Juice10 committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    41fa57a View commit details
    Browse the repository at this point in the history

  27. Check if url is of cacheable origin

    @Juice10
    Juice10 committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    336b649 View commit details
    Browse the repository at this point in the history

  28. Test: Add captureAssets config to meta event

    @Juice10
    Juice10 committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    71d61d9 View commit details
    Browse the repository at this point in the history

  29. object urls aren't stable so lets remove them

    @Juice10
    Juice10 committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    1f8eab3 View commit details
    Browse the repository at this point in the history

  30. inlineImages should work next to captureAssets for now

    @Juice10
    Juice10 committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    a636910 View commit details
    Browse the repository at this point in the history

  31. Fix asset caching bug

    @Juice10
    Juice10 committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    d1ce779 View commit details
    Browse the repository at this point in the history

  32. captureAssets on live-stream by default

    @Juice10
    Juice10 committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    d4df74b View commit details
    Browse the repository at this point in the history

  33. Fix asset URLs in events file

    @Juice10
    Juice10 committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    03c080c View commit details
    Browse the repository at this point in the history

  34. Update deprecated inlineImages option to use 

    captureAssets directly
    @Juice10
    Juice10 committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    67682ea View commit details
    Browse the repository at this point in the history

  35. Deprecate inlineImage config 

    option.
    @Juice10
    Juice10 committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    9934a9b View commit details
    Browse the repository at this point in the history

  36. Update snapshot to reflect current captureAssets

    @Juice10
    Juice10 committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    59a2f3a View commit details
    Browse the repository at this point in the history

  37. Make test less flaky

    @Juice10
    Juice10 committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    eb0e742 View commit details
    Browse the repository at this point in the history

  38. Cache attribute support for BODY, TABLE, 

    TD, TR, TH, TBODY, THEAD, image, feImage, and
cursor elements
    @Juice10
    Juice10 committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    f4b00eb View commit details
    Browse the repository at this point in the history

  39. Remove unused 'inlineImages' option

    @Juice10
    Juice10 committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    41655df View commit details
    Browse the repository at this point in the history

  40. Refactor AssetManager constructor signature

    @Juice10
    Juice10 committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    7e8ab97 View commit details
    Browse the repository at this point in the history

  41. Remove console.log statements in asset.test.ts

    @Juice10
    Juice10 committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    00835e5 View commit details
    Browse the repository at this point in the history

  42. Refactor reset method signature to accept optional 

    config parameter
    @Juice10
    Juice10 committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    4731136 View commit details
    Browse the repository at this point in the history

  43. Fix deserialized size comparison in deserializeArg 

    test
    @Juice10
    Juice10 committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    11e5b24 View commit details
    Browse the repository at this point in the history

  44. Apply formatting changes

    @Juice10
    Juice10 committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    fd395db View commit details
    Browse the repository at this point in the history

  45. Fix asset manager to only load assets from 

    cacheable origins
    @Juice10
    Juice10 committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    59a48a6 View commit details
    Browse the repository at this point in the history

  46. Update defaultPort in startServer function

    @Juice10
    Juice10 committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    1b56a29 View commit details
    Browse the repository at this point in the history

  47. Make test more reliable

    @Juice10
    Juice10 committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    7c7827a View commit details
    Browse the repository at this point in the history

  48. Add failing test for src attribute

    @Juice10
    Juice10 committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    ea0ea80 View commit details
    Browse the repository at this point in the history

  49. Remove failed asset event

    @Juice10
    Juice10 committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    40495f7 View commit details
    Browse the repository at this point in the history

  50. Add support for asset manager in rrdom 

    And remove attribute while asset is loading
    @Juice10
    Juice10 committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    4391960 View commit details
    Browse the repository at this point in the history

  51. Change asset manager path

    @Juice10
    Juice10 committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    e8fc652 View commit details
    Browse the repository at this point in the history

  52. Fix import path for AssetManager in asset-unit.test.ts

    @Juice10
    Juice10 committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    c94c656 View commit details
    Browse the repository at this point in the history

  53. Move isAttributeCacheable tests to rrweb-snapshot

    @Juice10
    Juice10 committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    97280a0 View commit details
    Browse the repository at this point in the history

  54. Make assetManager optional

    @Juice10
    Juice10 committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    f5c898b View commit details
    Browse the repository at this point in the history

  55. upgrade rrdom-nodejs to jest 29

    @Juice10
    Juice10 committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    a25ebab View commit details
    Browse the repository at this point in the history

  56. Update Jest and ts-jest versions to 29 in rrvideo

    @Juice10
    Juice10 committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    de0c6d5 View commit details
    Browse the repository at this point in the history

  57. add @types/prettier dependency

    @Juice10
    Juice10 committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    77ede21 View commit details
    Browse the repository at this point in the history

  58. upgrade dependencies

    @Juice10
    Juice10 committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    262ab0b View commit details
    Browse the repository at this point in the history

  59. Update jest to 29 and rollup to 4

    @Juice10
    Juice10 committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    73f811b View commit details
    Browse the repository at this point in the history

  60. Add esModuleInterop and allowSyntheticDefaultImports to tsconfig.json

    @Juice10
    Juice10 committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    a12966d View commit details
    Browse the repository at this point in the history

  61. Add support for updating srcset attribute in 

    AssetManager
    @Juice10
    Juice10 committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    02b0b6c View commit details
    Browse the repository at this point in the history

  62. Add support for SVG elements in AssetManager

    @Juice10
    Juice10 committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    7fc792f View commit details
    Browse the repository at this point in the history

  63. Drop support for caching xlink:href attributes 

    xlink:href is deprecated
Most modern browsers rewrite `xlink:href` to `href` which is currently supported
Tested in Firefox, Safari & Chrome
    @Juice10
    Juice10 committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    d33c95e View commit details
    Browse the repository at this point in the history

  64. Fix rrdom error: 

    "diff algorithm for rrdom › apply virtual style rules to node › should insert rule at index [0,0] and keep existing rules"
    @Juice10
    Juice10 committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    003babe View commit details
    Browse the repository at this point in the history

  65. Remove console.log statement in 

    AssetManager.manageAttribute
    @Juice10
    Juice10 committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    780fa5a View commit details
    Browse the repository at this point in the history

  66. Linux and Mac generate slightly different screenshots

    @Juice10
    Juice10 committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    c3a5ff2 View commit details
    Browse the repository at this point in the history

  67. Remove syntax error

    @Juice10
    Juice10 committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    f1d4961 View commit details
    Browse the repository at this point in the history

  68. Add wait for RAF before evaluating snapshots

    @Juice10
    Juice10 committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    c55edac View commit details
    Browse the repository at this point in the history

  69. Changeset: Added support for Asset Event and capturing many 

    different types of assets (not just img#src)
    @Juice10
    Juice10 committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    9d3ad51 View commit details
    Browse the repository at this point in the history

  70. Update puppeteer version in package.json

    @Juice10
    Juice10 committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    c280b1d View commit details
    Browse the repository at this point in the history

  71. Fix cross-origin iframe message forwarding test

    @Juice10
    Juice10 committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    0aa290f View commit details
    Browse the repository at this point in the history

  72. Make test more robust

    @Juice10
    Juice10 committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    3c9c443 View commit details
    Browse the repository at this point in the history

  73. Deprecate inlineImages and introduce captureAssets option

    @Juice10
    Juice10 committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    5e20cd7 View commit details
    Browse the repository at this point in the history

  74. Docs: add examples to getUrlsFromSrcset

    @Juice10
    Juice10 committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    ac72b3a View commit details
    Browse the repository at this point in the history

  75. Revert accidental change to backToNormal

    @Juice10
    Juice10 committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    51ebb82 View commit details
    Browse the repository at this point in the history

  76. Move @rrweb/types to devDependencies for rrweb-snapshot

    @Juice10
    Juice10 committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    fbf5b8b View commit details
    Browse the repository at this point in the history

  77. Remove console.log statements in asset-integration.test.ts

    @Juice10
    Juice10 committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    1f639fd View commit details
    Browse the repository at this point in the history

  78. Update packages/rrweb/src/replay/asset-manager/index.ts 

    Co-authored-by: Eoghan Murray <[email protected]>
    @Juice10 @eoghanmurray
    Juice10 and eoghanmurray committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    2a906ec View commit details
    Browse the repository at this point in the history

  79. Delay call until all attributes are present on the new node, in case … 

    …the AssetManager needs to interrogate other attributes to determine how to manage, e.g. <link with href depending on rel="stylesheet"
    @eoghanmurray @Juice10
    eoghanmurray authored and Juice10 committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    a0b615a View commit details
    Browse the repository at this point in the history

  80. Rename Cacheable -> Capturable

    @eoghanmurray @Juice10
    eoghanmurray authored and Juice10 committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    4415d74 View commit details
    Browse the repository at this point in the history

  81. Apply formatting changes

    @Juice10
    Juice10 committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    a5f56b8 View commit details
    Browse the repository at this point in the history

  82. Apply formatting changes

    @Juice10
    Juice10 committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    e27b6de View commit details
    Browse the repository at this point in the history

  83. Apply formatting changes

    @Juice10
    Juice10 committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    2d6ea8e View commit details
    Browse the repository at this point in the history

  84. Trigger CI again

    @Juice10
    Juice10 committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    8814e42 View commit details
    Browse the repository at this point in the history

  85. Apply formatting changes

    @Juice10
    Juice10 committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    5fc6616 View commit details
    Browse the repository at this point in the history

  86. Restore change due to faulty rebase

    @Juice10
    Juice10 committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    c160f50 View commit details
    Browse the repository at this point in the history