-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: change default value of input type from null to text #1200
Conversation
|
cc: @mydea |
This looks good to me. @mydea Do you think it's OK to set 'text' as the default value? |
This should not be necessary, because IMHO I would not do this change, because right now it will return I fixed this here: #1184 - maybe we can/should just add a comment indicating that |
@mydea and it would be helpful if you could also consider releasing [email protected] |
@re-fort 2.0.0-alpha.8 has been released! |
according to W3C, when omitting the type of input(e.g.
<input />
), the type must be treated as text.after #1170, that case is treated as null and is not masked correctly.
this PR resolves this.