Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: inline images onload #1174

Merged
merged 4 commits into from
Mar 13, 2023
Merged

Conversation

wfk007
Copy link
Contributor

@wfk007 wfk007 commented Mar 10, 2023

fix: #1172

@changeset-bot
Copy link

changeset-bot bot commented Mar 10, 2023

🦋 Changeset detected

Latest commit: bf006de

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
rrweb-snapshot Patch
rrweb Patch
rrdom Patch
rrdom-nodejs Patch
rrweb-player Patch
@rrweb/types Patch
@rrweb/web-extension Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@YunFeng0817 YunFeng0817 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your great contribution.

@eoghanmurray
Copy link
Contributor

There are some changes after yarn test:update following this PR that maybe were forgotten?

 @ -364,6 +364,12 @@ exports[`integration tests [html file]: picture-in-frame.html 1`] = `
   </body></html>"
 `;
+exports[`integration tests [html file]: picture-with-inline-onload.html 1`] = `
+"<html xmlns=\\"http://www.w3.org/1999/xhtml\\"><head></head><body>
+    <img src=\\"http://localhost:3030/images/robot.png\\" alt=\\"This is a robot\\" style=\\"opacity: 1;\\" _onload=\\"this.style.opacity=1\\" />
+  </body></html>"
+`;
+

eoghanmurray added a commit to eoghanmurray/rrweb that referenced this pull request Apr 5, 2024
eoghanmurray added a commit to eoghanmurray/rrweb that referenced this pull request May 7, 2024
eoghanmurray added a commit to eoghanmurray/rrweb that referenced this pull request May 14, 2024
eoghanmurray added a commit to eoghanmurray/rrweb that referenced this pull request May 15, 2024
Juice10 pushed a commit that referenced this pull request May 17, 2024
* Fix that the `.replace()` function only replaces the first occurrence

* This should have been included in #1174

* Create fast-pets-exist.md
jxiwang pushed a commit to amplitude/rrweb that referenced this pull request Jul 31, 2024
* Fix that the `.replace()` function only replaces the first occurrence

* This should have been included in rrweb-io#1174

* Create fast-pets-exist.md
jxiwang pushed a commit to amplitude/rrweb that referenced this pull request Oct 16, 2024
* Fix that the `.replace()` function only replaces the first occurrence

* This should have been included in rrweb-io#1174

* Create fast-pets-exist.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Inline images: add load listeners not replace
3 participants