fix: Recursive logging bug with console recording

[benjackwhite]

Originally reported here

Problem

Thanks to some debugging with a customer, we found an interesting "edge" case that can trigger an infinite loop via console logs. The context is this was a Vue.js app that was logging some warnings which contained objects within that warning with Proxied methods that triggered logs themselves.

The situation is like this (WARNING: If you run this with console log recording enabled your browser will freeze).

let target = {
  foo: "bar"
};

const handler = {
  get(target, prop, receiver) {
    if (prop === "foo") {
      console.warn("foo was accessed. This shouldn't be done... Context:", target)
    }
    return Reflect.get(...arguments);
  },
};

const proxy = new Proxy(target, handler);
target.proxy = proxy

console.log(proxy); 

1. We log the proxy object
2. The console log is intercepted by our code
3. It creates a "copy" of the object via stringifying
4. This triggers the proxied get call which itself is logging a warning
5. ... which triggers Step 2 and now we have a loop 🙈

Solution

• Flag when we enter the block to stringify and callback the code. If any console logs occur in that time, we don't capture them to avoid infinite loops

[changeset-bot]

🦋 Changeset detected

Latest commit: cdec9e6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages

Name	Type
rrweb	Patch
rrweb-snapshot	Patch
rrdom	Patch
rrdom-nodejs	Patch
rrweb-player	Patch
@rrweb/types	Patch
@rrweb/web-extension	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[YunFeng0817]

This a very interesting edge case. Thanks for your great description and fix.

[YunFeng0817]

Could you please help us add the change log? Seems like I don't have permission to add it to your branch.

[benjackwhite]

Happily! (How do I do that? 😅 ) Perhaps something to add to the PR template?

[benjackwhite]

@YunFeng0817 I think I did it? (I just clicked the link in the bots comment but please double check I got that right 🙈 )

[YunFeng0817]

@benjackwhite Yes, you did. I will merge it once CI passes.