Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

some minor changes for releasing the extension and revert failed publish PR #1123 #1132

Merged
merged 3 commits into from
Feb 14, 2023
Merged

some minor changes for releasing the extension and revert failed publish PR #1123 #1132

merged 3 commits into from
Feb 14, 2023

Conversation

YunFeng0817
Copy link
Member

@YunFeng0817 YunFeng0817 commented Feb 14, 2023 •
edited
Loading

  1. The vite-plugin-zip don't support enough option to config.
  2. Skip adding recorder to same-origin iframes.
  3. revert failed PR Version Packages (alpha) #1123

@changeset-bot
Copy link

changeset-bot bot commented Feb 14, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: be74c65

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Juice10
Juice10 approved these changes Feb 14, 2023
View reviewed changes
Copy link
Contributor

@Juice10 Juice10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@YunFeng0817 YunFeng0817 changed the title some minor changes for releasing the extension some minor changes for releasing the extension and revert failed publish PR #1123 Feb 14, 2023
@YunFeng0817 YunFeng0817 merged commit 033d2d1 into master Feb 14, 2023
@YunFeng0817 YunFeng0817 deleted the extension-release branch February 15, 2023 06:07
This was referenced Jul 6, 2023
Closed
Closed
Closed
@billyvg billyvg mentioned this pull request Jul 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Juice10 Juice10 Juice10 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YunFeng0817 @Juice10