-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve rrdom performance #1127
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add try catch to some fragile points
this happens when ids of doctype or html element are changed in the virtual dom also improve the code quality
reduce the complexity from O(n) to O(logn) a specific benchmark is needed to add further
🦋 Changeset detectedLatest commit: 3f6eb9e The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Juice10
approved these changes
Feb 14, 2023
This was referenced Feb 14, 2023
This was referenced Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Performance Issue
In the repo benchmark-events, I uploaded one huge event data file. This file is recorded on the page https://bugs.chromium.org/p/chromium/issues/list?mode=grid with the rrweb browser extension.
The performance of rrdom is challenged in this situation.
From the screenshot of the performance profile, we can see that the contains function in rrdom is a performance bottleneck. Besides, as @Yuyz0112 has mentioned before (#853 (comment)), the current implementation for storing nodes with array data structure may cause a lot of iteration when inserting new nodes into the tree.
benchmark result before the optimization
Optimization
benchmark result after the optimization
After the optimization, from the performance profile, there's no more significant performance bottleneck in RRDom anymore. The performance improvement under this scenario is around 80%.