Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add option to record on DOMContentLoaded event #1109

Merged
merged 5 commits into from
Feb 9, 2023
Merged

add option to record on DOMContentLoaded event #1109

merged 5 commits into from
Feb 9, 2023

Conversation

YunFeng0817
Copy link
Member

@YunFeng0817 YunFeng0817 commented Feb 5, 2023 •
edited
Loading

Fixes #1090

  • Add an option 'recordAfter' which can customize the initialization time of the recorder.
  • Add doc for the option
  • Add an integration test case

Helpful info:

  1. When DOMContentLoaded is emitted, the readyState of the document is interactive.
  2. When load is emitted, the readyState of the document is 'complete'.

@YunFeng0817 YunFeng0817 marked this pull request as draft February 5, 2023 12:57
@YunFeng0817 YunFeng0817 marked this pull request as ready for review February 6, 2023 06:00
@YunFeng0817 YunFeng0817 added the 2.0 label Feb 6, 2023
jlalmes
jlalmes approved these changes Feb 7, 2023
View reviewed changes
Copy link
Contributor

@jlalmes jlalmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@YunFeng0817 YunFeng0817 changed the title use DOMContentLoaded event rather than load event add option to record on DOMContentLoaded event Feb 8, 2023
@Juice10 Juice10 merged commit 0627d4d into master Feb 9, 2023
@Juice10 Juice10 deleted the load-life-circle branch February 9, 2023 09:14
This was referenced Feb 12, 2023
Merged
Closed
Closed
Merged
This was referenced Jul 6, 2023
Closed
Closed
Closed
@billyvg billyvg mentioned this pull request Jul 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlalmes jlalmes jlalmes approved these changes

@Juice10 Juice10 Juice10 approved these changes

Assignees
No one assigned
Labels
2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Recorder initializes very late in page load lifecycle
3 participants
@YunFeng0817 @Juice10 @jlalmes