fix: bug when handling shadow doms #1041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On the website https://mixpanel.com/project/2195193/view/139237/app/dashboards#id=3679845, the bottom chart makes the recorder crash (infinite loop)
Yuyz0112
approved these changes
Oct 31, 2022
|
LGTM, any chance to add some tests before we merge this? |
|
I find it really hard to construct a test case for this. I tried to partially extracted the dom structure and the corner case didn't show up. |
Vadman97
added a commit
to highlight/highlight
that referenced
this pull request
Nov 4, 2022
## Summary Updates rrweb and adds shadow-dom test under `/1/buttons` that is invoked from cypress. ## How did you test this change? New buttons changes that crash without fix (rrweb-io/rrweb#1041) and work after before: https://www.loom.com/share/12c58018a8314d2fbeb691e462a94aed after: https://www.loom.com/share/c490d0b8bc194214a47e61832ae57d43 cypress test frozen without the fix https://www.loom.com/share/8f35a9c5cb164cec956a263c91001f2a and frozen in CI https://github.com/highlight-run/highlight/actions/runs/3390553816/jobs/5634828642 ## Are there any deployment considerations? Updating firstload version.
|
Hey, thanks for fixing the bug! Do you happen to have an ETA for the fixed version? |
This was referenced Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
On the website https://mixpanel.com/project/2195193/view/139237/app/dashboards#id=3679845, the bottom chart makes the recorder crash (in an infinite loop)
How to reproduce:
How to fix:
The chart is an SVG inside a shadow dom. The complicated dom structure raises a corner case for the recording code of shadow dom #956. In this case, the unhandled node is not a direct child of the shadow host and its parent node is not supposed to be the shadow host element. So I add code to check whether the unhandled node is a direct child of shadow dom or not. I tried to reproduce this through a simplified test case but I failed.