2 commits for optimizing chore #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 2, 2020 20:46
…nvenience for building components in other framework and typescrpit
Joeoeoe
changed the title
|
Thanks, looks reasonable to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I push 2 commits.
commit: 303d9fd
fix the bug when build svelte application.
When using rollup-plugin-svelte, there is a error:
And I find the solution at Error: Package subpath './compiler.js' is not defined by "exports" in node_modules/svelte/package.json.
And update the rollup-plugin-svelte in package.json, install, build again:
commit: a5c3447
I am building a react component base on rrweb-player with typescript, and when I run
npx tsc, there is an error with typescript:It seems that because of the use of the @tsconfig/svelte/tsconfig.json in devDependencies. Could move it to the dependencies for convinence when building other framework component?