Fix false positive in ParenthesesInCondition

Fixes #461
rrrene · Nov 4, 2017 · 9b338a8 · 9b338a8
1 parent 8a8a9c6
commit 9b338a8
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/lib/credo/check/readability/parentheses_in_condition.ex b/lib/credo/check/readability/parentheses_in_condition.ex
@@ -81,6 +81,11 @@ defmodule Credo.Check.Readability.ParenthesesInCondition do
   defp check_for_closing_paren(_start, {:")", _}, [{:and_op, _, _} | _tail], _prev_head) do
     false
   end
+  # matches:  if( 1 &&& foo ) > bar do
+  #                           ^
+  defp check_for_closing_paren(_start, {:")", _}, [{:rel_op, _, _} | _tail], _prev_head) do
+    false
+  end
   # matches:  if( something ), do:
   #                         ^^
   defp check_for_closing_paren(start, {:",", _}, _, {:")", _}) do

diff --git a/test/credo/check/readability/parentheses_in_condition_test.exs b/test/credo/check/readability/parentheses_in_condition_test.exs
@@ -38,6 +38,16 @@ defmodule CredoSampleModule do
     if (thing && other_thing) || better_thing, do: something
     if !better_thing && (thing || other_thing), do: something_else
   end
+
+  import Bitwise
+
+	def bar(foo, bar) do
+		if (foo &&& 0b1000) > 0, do: bar, else: nil
+	end
+
+	def foobar(foo) do
+		foo
+  end
 end
 """ |> to_source_file
     |> refute_issues(@described_check)