Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix build instructions #57

Merged
merged 1 commit into from
Oct 22, 2022

Conversation

newca12
Copy link
Contributor

@newca12 newca12 commented Aug 25, 2022

fix #52
If you want to lean more about this issue check : https://stackoverflow.com/a/1032653

From git version 1.8.3 to the latest version.
git submodule update --init --recursive will not check out the uptodate submodule.
--remote is required

Building without --remote fetch the old Rust.stg template and the visitor feature introduce in V0.3 will not work.
Nevetheless the released V0.3.0 asset antlr4-4.8-2-SNAPSHOT-complete.jar is OK which is a bit surprising.

@rrevenantt
Copy link
Owner

Thanks, i am not sure why you find it surprising tho, release assets are built and uploaded directly from CI which fetches target commit directly.

@newca12
Copy link
Contributor Author

newca12 commented Aug 29, 2022

The CI use /usr/bin/git -c protocol.version=2 submodule update --init --force --depth=1
so the wrong old submodule version is checkout
Submodule path 'runtime/Rust': checked out '76d0a7dde296bb194242a1430d88fdd6b79ac2eb'

but the released artifact is indeed correct thanks to the next github action

      - run: |
          git fetch origin $GITHUB_REF
          git checkout FETCH_HEAD

which ensure the right module refresh HEAD is now at 4779134 v0.3 prerelease (#29)

This is not that obvious but if you know what you are doing this is fine as the Checkout Submodule Action which was doing this properly is not maintened anymore.

@rrevenantt rrevenantt merged commit b7660bc into rrevenantt:master Oct 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build instructions are not correct for V0.3 prerelease
2 participants