Save interpreter_base and ld_path at AddressSpace construction. #2747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This aids compatibility with GDB 10.1. Related issue rr-debugger#2740.
|
This looks good. Ideally we'd also have a test for this. The test would use iterate_maps to search for the interpreter mapping and unmap its first page, I guess, and we'd need a gdb script. |
|
I think in this case I'm going to ask nicely for a test but not require it if it's too hard. |
|
Let me have a look, but might take some time. |
bernhardu
changed the title
Retrieving the interpreter_base fails if done after interpreter gets invalidated. Related to rr-debugger#2740
bernhardu
force-pushed
the
2740-gdb101-2
branch
from
b2a289c to
71134b4
Compare
bernhardu
changed the title
|
The added test invalid_interpreter fails at x86_64 if the first patch to rr is not applied, but succeeds if both patches are applied. |
|
Great thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aids compatibility with GDB 10.1.
Related issue #2740.