Keyboard and mouse event fixes #661
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`this` became inaccessible from hide() when the function was called from outside. Note: I don't like the behavior of Escape and Delete, as pressing them more than once reverses their action.
Also fixes moving notes by arrow keys. Removed left click detection IE8 hack we inherited from the original visionmedia/page.js code (cf. https://unixpapa.com/js/mouse.html) as proper KeyboardEvent.key was introduced in IE9 and it's time to move on. ArrowUp/Down/Left/Right names have to be mangled to maintain IE9 compat.
Browsers no longer fire the primary 'click' event for middle clicks. Old way kept for compatibility as it doesn't hurt anything. All browsers that support auxclick also have standardized MouseEvent.button values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #660
Each commit fixes one of three broken features: