Pug support #93
Closed
Pug support #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ease package.json update reflects the addition). Alphabetized dependency list and added pugg as an optional dependency.
…maintains compatibility with jade template rendering.
|
Thanks? It was pretty trivial to fix the merge issues; you could have commented on my PR for the update. |
|
No problem... In my experience, maintainers often don't consider PRs with merge conflicts, and since I'd pulled your fork down already for testing, I simply rebased it, resolved, and pushed it back upstream. The commits are all still yours! 😄 |
|
Fwiw, I was able to use this succesfully by putting |
|
@tyriker Can you please handle the merge conflicts for this pull request. |
|
@rquadling this is the same work in #89 |
|
@rquadling @bennorwood |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is @bennorwood's work from his original PR #89 (thanks Ben!)
I took his fork and made sure it worked for me (I need Pug processing in html2js), then rebased it with the latest from rquadling/grunt-html2js/master to resolve the existing conflicts, then made sure it still worked.
Submitting this PR to hopefully get Pug support added officially (even if still in beta), and partially resolve #83 (it doesn't remove Jade).
This PR may be easier to merge since PR #89 now contains conflicts.