Basic auth support #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otoolep
force-pushed
the
basic_auth_support
branch
from
656d4ef
to
c1ad8c8
Compare
otoolep
force-pushed
the
basic_auth_support
branch
3 times, most recently
from
65522bd
to
94876e6
Compare
otoolep
force-pushed
the
basic_auth_support
branch
from
94876e6
to
e374c88
Compare
|
@zmedico -- if you have any time, let me know what you think of the functionality added by this PR. You can read about it here: https://github.com/otoolep/rqlite/blob/basic_auth_support/SECURITY.md |
|
It looks very nice @otoolep, thanks for asking. I'd like to add support for these features to the python driver ASAP. |
otoolep
force-pushed
the
basic_auth_support
branch
from
6d5bc86
to
4ae1d0d
Compare
otoolep
force-pushed
the
basic_auth_support
branch
from
4ae1d0d
to
f94a104
Compare
|
OK, cool @zmedico -- merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/otoolep/rqlite/issues/83