Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

verifySignature(): package signatures must be PGPSIGTYPE_BINARY #1705

Conversation

DemiMarie
Copy link
Contributor

RPM packages are binary documents and must be signed as such.

RPM packages are binary documents and must be signed as such.
@pmatilai
Copy link
Member

pmatilai commented Jun 17, 2021

The difference between binary and text signature is how their hash is calculated, and a correctly calculated text document signature simply does not verify when calculated as a binary signature, which is how we treat all signatures. So this is besides the point and doesn't accomplish anything but add another struct pgpDigParams direct access when we're trying to eliminate those. NAK.

@pmatilai pmatilai closed this Jun 17, 2021
@DemiMarie
Copy link
Contributor Author

The difference between binary and text signature is how their hash is calculated, and a correctly calculated text document signature simply does not verify when calculated as a binary signature, which is how we treat all signatures. So this is besides the point and doesn't accomplish anything but add another struct pgpDigParams direct access when we're trying to eliminate those. NAK.

For clarification: would you be okay with the patch if it did not directly access the members of struct pgpDigParams?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants