Better detection of I/O errors (#1566)

It is possible for fprintf to have flushed the stream already, in which case fflush will succeed. Use ferror() to catch that. Fixes 95a8333.
rpm-software-management · Mar 15, 2021 · 23f1166 · 23f1166
1 parent 23770e1
commit 23f1166
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/lib/poptALL.c b/lib/poptALL.c
@@ -132,9 +132,11 @@ static void rpmcliAllArgCallback( poptContext con,
 	{   char *val = NULL;
 	    if (rpmExpandMacros(NULL, arg, &val, 0) < 0)
 		exit(EXIT_FAILURE);
-	    fprintf(stdout, "%s\n", val);
-	    if (fflush(stdout) == EOF) {
+	    if (fprintf(stdout, "%s\n", val) < 0 ||
+		fflush(stdout) == EOF ||
+		ferror(stdout)) {
 	        perror(_("Error writing to stdout"));
+		free(val);
 	        exit(EXIT_FAILURE);
 	    }
 	    free(val);