Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate / use OCI image for Mock buildroot #1489

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

praiskup
Copy link
Member

Fixes: #1482

@praiskup praiskup marked this pull request as draft October 22, 2024 11:09
@pep8speaks
Copy link

pep8speaks commented Oct 22, 2024

Hello @praiskup! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-10-31 21:43:13 UTC


def _produce_image_as_root(self):
name = f"mock-container-{self.buildroot.config['root']}"
# TODO: chain build produces multiple buildroots
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No action neeeded, tarballs are created in sub-directories

$ find /var/tmp/mock-chain-root-377278-t9wkx5vm/results/ | grep tar$
/var/tmp/mock-chain-root-377278-t9wkx5vm/results/epel-10-x86_64/python-types-requests-2.26.1-14.fc42/buildroot-oci.tar
/var/tmp/mock-chain-root-377278-t9wkx5vm/results/epel-10-x86_64/python-requests-toolbelt-1.0.0-7.fc42/buildroot-oci.tar
/var/tmp/mock-chain-root-377278-t9wkx5vm/results/epel-10-x86_64/python-freezegun-1.2.2-9.fc42/buildroot-oci.tar
/var/tmp/mock-chain-root-377278-t9wkx5vm/results/epel-10-x86_64/copr-cli-2.0-1.el10_0/buildroot-oci.tar
/var/tmp/mock-chain-root-377278-t9wkx5vm/results/epel-10-x86_64/python-responses-0.18.0-1.el9/buildroot-oci.tar
/var/tmp/mock-chain-root-377278-t9wkx5vm/results/epel-10-x86_64/python-humanize-4.9.0-2.fc42/buildroot-oci.tar
/var/tmp/mock-chain-root-377278-t9wkx5vm/results/epel-10-x86_64/python-copr-2.0-1.fc41/buildroot-oci.tar

@xsuchy
Copy link
Member

xsuchy commented Oct 24, 2024

LGTM so far.

@praiskup praiskup changed the title Generate OCI image from buildroot Generate / use OCI image for Mock buildroot Oct 29, 2024
@praiskup praiskup force-pushed the praiskup-buildroot-oci-image branch 3 times, most recently from c0cd55d to ef58c30 Compare October 29, 2024 18:05
We plan to use the podman.pi library and buildroot logic  both for
buildroot and bootstrap, let's not not hard-wire code bootstrap-only.
The 'podman image mount' requires image tag, but from-tarball imports
have no tag (create one).
For now as:
--config-opts buildroot_image=registry.fedoraproject.org/fedora:41

Fixes: rpm-software-management#1159
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mock as tool to prepare container image with rpm-build only
3 participants