podman: experiment with "fallback to normal bootstrap" #1200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
praiskup
force-pushed
the
praiskup-fallback-bootstrap-image
branch
5 times, most recently
from
cb74219 to
d6f9dc4
Compare
praiskup
force-pushed
the
praiskup-fallback-bootstrap-image
branch
4 times, most recently
from
7839ed8 to
e1ad979
Compare
|
@xsuchy can you please re-review? I've also added retry-mechanism. |
praiskup
force-pushed
the
praiskup-fallback-bootstrap-image
branch
from
e1ad979 to
757b8ad
Compare
xsuchy
reviewed
Aug 29, 2023
| try: | ||
| yield | ||
| except BootstrapError as exc: | ||
| if not self.config["image_fallback"]: |
There was a problem hiding this comment.
image_fallback or bootstrap_image_fallback?
There was a problem hiding this comment.
Ahh, in bootstrap it is without the prefix. Ignore my comment.
praiskup
force-pushed
the
praiskup-fallback-bootstrap-image
branch
from
757b8ad to
d19c01c
Compare
|
Thank you for taking a look! |
praiskup
added a commit
to praiskup/mock
that referenced
this pull request
Aug 29, 2023
When Podman isn't installed, or the image can not be downloaded, or the image isn't compatible with host arch - Mock newly falls-back to a normal 'dnf --installroot' when bootstrap_image_fallback=True (default). Closes: rpm-software-management#1200
praiskup
added a commit
to praiskup/mock
that referenced
this pull request
Aug 29, 2023
Move podman_check_native_image_architecture() to the later stage, so we don't retry upon architecture mismatch. Relates: containers/podman#19770 Closes: rpm-software-management#1200
praiskup
force-pushed
the
praiskup-fallback-bootstrap-image
branch
from
d19c01c to
ee8f26f
Compare
|
rebased |
When Podman isn't installed, or the image can not be downloaded, or the image isn't compatible with host arch - Mock newly falls-back to a normal 'dnf --installroot' when bootstrap_image_fallback=True (default). Closes: rpm-software-management#1200
Move podman_check_native_image_architecture() to the later stage, so we don't retry upon architecture mismatch. Relates: containers/podman#19770 Closes: rpm-software-management#1200
This message may be raised when /bin/podman fails for any reason, not just when that image arch != host arch.
praiskup
force-pushed
the
praiskup-fallback-bootstrap-image
branch
from
ee8f26f to
a056d52
Compare
|
Sorry for yet another rebase, I believe the code is now a bit clearer. |
praiskup
added a commit
that referenced
this pull request
Aug 30, 2023
When Podman isn't installed, or the image can not be downloaded, or the image isn't compatible with host arch - Mock newly falls-back to a normal 'dnf --installroot' when bootstrap_image_fallback=True (default). Closes: #1200
praiskup
added a commit
that referenced
this pull request
Aug 30, 2023
Move podman_check_native_image_architecture() to the later stage, so we don't retry upon architecture mismatch. Relates: containers/podman#19770 Closes: #1200
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs to be applied on top of #1199, if at all.