Bootstrap image - no package management updates needed? #1126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 21, 2023
|
See also the fedora-kickstarts proposal. |
praiskup
force-pushed
the
praiskup-bootstra-image-features
branch
2 times, most recently
from
1f366d3 to
267df1e
Compare
xsuchy
reviewed
Jun 28, 2023
| @@ -83,6 +83,7 @@ def setup_default_config_opts(): | |||
| config_opts['use_bootstrap'] = True | |||
| config_opts['use_bootstrap_image'] = False | |||
| config_opts['bootstrap_image'] = 'fedora:latest' | |||
| config_opts['bootstrap_image_ready'] = False | |||
There was a problem hiding this comment.
Can this be documented in site-defaults.cfg too?
There was a problem hiding this comment.
True, thank you for pointing that out!
There's a new option config_opts['bootstrap_image_ready'] which, if set, causes that Mock doesn't try to install any tooling into it (silently expecting that 'dnf' and 'dnf builddep' works inside). Turns out that e.g. the ubi8 and ubi9 images have the 'builddep' command installed by default, therefore we can turn this option ON by default. Fixes: rpm-software-management#1088
praiskup
force-pushed
the
praiskup-bootstra-image-features
branch
from
267df1e to
1b81b11
Compare
xsuchy
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.