Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable use_bootstrap_image by default #1101

Merged
merged 2 commits into from
Jul 20, 2023

Conversation

xsuchy
Copy link
Member

@xsuchy xsuchy commented Jun 6, 2023

This feature exists for long time. I think it is time to enable it by default. It will allows us to run Mock without package manager on host.

@praiskup
Copy link
Member

praiskup commented Jun 7, 2023

This really can make building RPMs trivial on non-RPM systems, e.g., I was hesitant to underline this too much as I haven't really tested this feature on other distributions (just tested in podman fedora:rawhide container after removing *dnf* packages). IMO we can consider Mock package existence in PyPI meaningful now.

While the feature and idea are relatively old, it has been recently reworked in 4.0+, and I'm curious whether we need some planning or blogging in advance before we do the hard switch. E.g. #1088 raises some important questions related to potential fixes/enhancements in this feature.

@praiskup
Copy link
Member

Cross arch is a problem, too, see #1101.

@xsuchy xsuchy force-pushed the use_bootstrap_image branch from 3324a4d to 9f30f43 Compare July 17, 2023 09:01
@xsuchy
Copy link
Member Author

xsuchy commented Jul 17, 2023

Updated.

@xsuchy xsuchy force-pushed the use_bootstrap_image branch from 9f30f43 to ca7df5b Compare July 17, 2023 11:56
@praiskup
Copy link
Member

Sorry, I'm jumping here and there today :-( We discussed also s/Suggests: podman/Recommends: podman/

@praiskup
Copy link
Member

Otherwise, I think we can go with this. @tkopecek / @nirik Koji with Mock 5.0+ could need a switch back option to use_bootstrap_image = False, at least as long as we don't also configure the bootstrap_image appropriately. Do we need an issue for this, or any other tracking?

@praiskup
Copy link
Member

JFTR, Copr already has a knob for enabling/disabling the bootstrap image feature, with Mock 5.0 in Copr we'll jump to the --use-bootstrap-image default for most of the projects.

@tkopecek
Copy link
Contributor

Created https://pagure.io/koji/issue/3872 - but it is not blocked for anything (builders' site-defaults can still be used for default behaviour override)

xsuchy added 2 commits July 17, 2023 18:29
This feature exists for long time. I think it is time to enable it by default.
It will allows us to run Mock without package manager on host.
the images are reported to be broken and does not work with Mock (or at all)
When the state change (and somebody will test it) we can enable it to use this feature.
@xsuchy xsuchy force-pushed the use_bootstrap_image branch from ca7df5b to 1da699b Compare July 17, 2023 16:29
@xsuchy
Copy link
Member Author

xsuchy commented Jul 17, 2023

Updated once again. :)

Copy link
Member

@praiskup praiskup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@praiskup
Copy link
Member

This has been open for a long time, and there are no objections (except for my own, and those have been more or less resolved). With #1152 and e7139e1, seems like a pretty nice mock-buildling evolution :-)

@praiskup
Copy link
Member

Thank you!

@praiskup praiskup merged commit ff554be into rpm-software-management:main Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants