gpg: Check is_selinux_enabled() before trying to label #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default for container execution is that `/sys/fs/selinux` is not mounted, and the libselinux library function `is_selinux_enabled` should be used to dynamically check if the system should attempt to perform SELinux labeling. This is how it's done by rpm, ostree, and systemd for example. But this code unconditionally tries to label if it finds a policy, which breaks in an obscure corner case when executed inside a container when we're not using overlayfs for the backend.
cgwalters
force-pushed
the
check-selinux-enabled
branch
from
17ae17a to
b0318e6
Compare
|
Corresponding libdnf PR rpm-software-management/libdnf#1665 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default for container execution is that
/sys/fs/selinuxis not mounted, and the libselinux library functionis_selinux_enabledshould be used to dynamically check if the system should attempt to perform SELinux labeling.This is how it's done by rpm, ostree, and systemd for example.
But this code unconditionally tries to label if it finds a policy, which breaks in an obscure corner case
when executed inside a container when we're not using overlayfs for the backend.