Fix error handling, Fix examples and build them #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Examples are not build, so the bug was ignored for long time.
jrohel
force-pushed
the
fixes_build_examples
branch
from
732db95 to
ad51123
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Possible usage of uninitialized value in lr_handle_network_wait
Fix:
lr_gpg_import_key,lr_gpg_import_key_from_fd: Don't ignore input file errorsFix: Removal of warnings "don't set value that will not be read"
The "examples" directory is part of the librero. The "download_low_level_api.c" example contained an error that prevented it from compiling. The examples were not compiled and therefore the error was ignored for a long time. Fixed the C examples and added CMakeFile.txt to build them.