Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include dist-info for python3-libdnf #1630

Conversation

evan-goode
Copy link
Member

This is the libdnf version of this patch [0] for DNF 4.

Per [1], Python packages should include some minimal distribution metadata, e.g. to make the package appear in pip list.

[0] rpm-software-management/dnf#1997
[1] https://packaging.python.org/en/latest/specifications/core-metadata/#core-metadata

= changelog =
msg: Add metadata for libdnf Python package
type: bugfix

@evan-goode evan-goode self-assigned this Oct 9, 2023
@evan-goode evan-goode requested a review from jan-kolarik October 9, 2023 18:44
Copy link
Member

@jan-kolarik jan-kolarik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jan-kolarik
Copy link
Member

jan-kolarik commented Oct 10, 2023

Hmm, I've noticed there is not your username connected with the commit. Do you want to modify that? The same thing is with the already pushed dnf PR ...
image
In the git log there is Author: Your Name <[email protected]>.

This is the libdnf version of this patch [0] for DNF 4.

Per [1], Python packages should include some minimal distribution
metadata, e.g. to make the package appear in `pip list`.

[0] rpm-software-management/dnf#1997
[1] https://packaging.python.org/en/latest/specifications/core-metadata/#core-metadata

= changelog =
msg: Add metadata for `libdnf` Python package
type: bugfix
@evan-goode evan-goode force-pushed the evan-goode/dist-info branch from 885bd36 to 2f1538f Compare October 10, 2023 14:45
@evan-goode
Copy link
Member Author

Oh thanks, something wiped out my git config. Just fixed it. I noticed that after the dnf PR was merged but I thought I had fixed it before committing this.

I'm guessing it would not be easy to fix the issue in dnf? It is still the last commit so perhaps a force push would not disrupt anyone's work.

@jan-kolarik
Copy link
Member

Oh thanks, something wiped out my git config. Just fixed it. I noticed that after the dnf PR was merged but I thought I had fixed it before committing this.

I'm guessing it would not be easy to fix the issue in dnf? It is still the last commit so perhaps a force push would not disrupt anyone's work.

Hmm, looking into some comments in this SO question, I'd rather keep the remote as it is 🙂

@evan-goode
Copy link
Member Author

Alright, I think we can live with it.

@jan-kolarik jan-kolarik merged commit fd2d936 into rpm-software-management:dnf-4-master Oct 10, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants