log: Preserve log messages during RPM transaction #1772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is an issue with RotatingFileLogger where log messages during an RPM transaction in installroot fail to be recorded. When RPM enters a chroot environment during the transaction, the path resolution changes, and RotatingFileLogger attempts to reopen the log file from its disk path for each message. However, once inside the chroot, the log file path can no longer be resolved, leading to a failure in logging until the RPM transaction completes. This patch modifies the RotatingFileLogger behavior to keep the log file descriptor open, ensuring continuous logging throughout the RPM transaction.
jrohel
approved these changes
Oct 15, 2024
There was a problem hiding this comment.
There is still a problem if there is a nested installroot with the same path in installroot.
Example:
dnf5 --installroot=/containers/test upgrade
and there exists /containers/test/containers/test/var/log/ (nested installroot). Messages from rpm callbacks will be logged to the nested installroot.
But in general PR improves the situation.
|
Thanks for the PR. Except for the nested installroot case, PR fixes the logging of RPM callbacks for installroot. I will merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an issue with RotatingFileLogger where log messages during an
RPM transaction in installroot fail to be recorded. When RPM enters a
chroot environment during the transaction, the path resolution changes,
and RotatingFileLogger attempts to reopen the log file from its disk
path for each message. However, once inside the chroot, the log file
path can no longer be resolved, leading to a failure in logging until
the RPM transaction completes.
This patch modifies the RotatingFileLogger behavior to keep the log file
descriptor open, ensuring continuous logging throughout the RPM
transaction.
Resolves: #1717