comps: add get_base() to {Group,Environment}{,Query} #1722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This mirrors the similar classes in libdnf5::rpm that provide the same methods. This will help fedrq implement group querying functionality.
gotmax23
commented
Sep 24, 2024
| @@ -24,8 +24,10 @@ | |||
| class TestCompsIterators(base_test_case.BaseTestCase): | |||
| def test_group_query_iterable(self): | |||
| query = libdnf5.comps.GroupQuery(self.base) | |||
| self.assertIsInstance(query.get_base().get(), libdnf5.base.Base) | |||
| _ = [grp.get_groupid() for grp in query] | |||
There was a problem hiding this comment.
I wanted to test get_base() on the Group/Environment classes, as well, but this test is broken and doesn't actually contain anything in the query.
There was a problem hiding this comment.
Indeed, can I please ask you to fix both of them (test_group_query_iterable and test_environment_query_iterable)?
Adding
self.add_repo_repomd("repomd-comps-core")as the first line of the tests should do the trick.
Also I think asserting that the query size is non zero would good.
Otherwise it look good.
Thank you.
Check that get_base() works properly in the Python bindings and that the query is not empty.
|
Thank you! |
Merged
via the queue into
rpm-software-management:main
with commit Oct 7, 2024
0061510
16 of 20 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mirrors the similar classes in libdnf5::rpm that provide the same methods. This will help fedrq implement group querying functionality.