I18N: Mark messages in "dnf install" output for a translation #1696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We were not able to find or create Copr project Unless the HTTP status code above is >= 500, please check your configuration for:
|
Many texts were always in English because the code did not
internatialinze them. This patch fixes it.
fmt::format() calls were replaced with libdnf5::utils::sformat()
calls to be able to pass a localized string as a formatting string.
Sentences glued from words, e.g. "Installing dependencies:" in
a transaction table, were changed to a single-string sentences in the
code. Having a full sentece is important for the translators.
I fixed spelling at few places, especially around importing PGP keys.
I used internatinoalized plural forms in the transaction summary
("Installing: 1 package" vs "Installing: 2 packages").
I also internationalized output to DNF log. At the end, it's
a human-oriented text.
I intentionally left out libdnf_throw_assertion() arguments from the
internationalization because that function needs changing its
implmentation to accept nonconst-literal formatting string. That will
be implemented in a separate patch.
I manully tested significant parts of the output to be sure the
messages propetly undergo localization.
Resolves: rpm-software-management#1688
ppisar
force-pushed
the
i18n_transaction_table
branch
from
1da7b6b
to
42dbc60
Compare
Merged
via the queue into
rpm-software-management:main
with commit Sep 16, 2024
8ad4614
12 of 20 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many texts were always in English because the code did not internatialinze them. This patch fixes it.
fmt::format() calls were replaced with libdnf5::utils::sformat() calls to be able to pass a localized string as a formatting string.
Sentences glued from words, e.g. "Installing dependencies:" in a transaction table, were changed to a single-string sentences in the code. Having a full sentece is important for the translators.
I fixed spelling at few places, especially around importing PGP keys.
I used internatinoalized plural forms in the transaction summary ("Installing: 1 package" vs "Installing: 2 packages").
I also internationalized output to DNF log. At the end, it's a human-oriented text.
I intentionally left out libdnf_throw_assertion() arguments from the internationalization because that function needs changing its implmentation to accept nonconst-literal formatting string. That will be implemented in a separate patch.
I manully tested significant parts of the output to be sure the messages propetly undergo localization.
Resolves: #1688