-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better error messages for system state loading #1623
Conversation
bfb591a
to
b04e7c8
Compare
/packit copr-build |
Please rebase against the latest changes so we can see the build is OK now. Thanks! |
b04e7c8
to
3dfd858
Compare
Done, let's see the results... |
doc/misc/system-state.7.rst
Outdated
Description | ||
=========== | ||
|
||
The DNF5 system state consists of several TOML files located in the /usr/lib/sysimage/libdnf5/ directory. DNF5 uses the system state to: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The /usr/lib/sysimage/libdnf5/
is the default but I think we should mention that the location is taken from system_state_dir
config option.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right. I'll fix it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Interestingly, there are some TOML unit tests failing, though after merging the #1625 it was green:
EDIT: Oh I see it's actually related to the PR :) |
There are multiple exceptions that can occur during loading the system state from toml files. Now they are caught and wrapped in StateLoadError.
The page also contains information how to recover from corrupted system state files.
3dfd858
to
e147626
Compare
Fixed. |
Add a man page on DNF system state. This man page is then referenced in system state loading error messages.
Resolves: #1550
Changes:
ac68a07 (Marek Blaha, 5 days ago)
doc: Add man page describing the system state
The page also contains information how to recover from corrupted system
state files.
888d955 (Marek Blaha, 5 days ago)
state: Catch all errors during system state load
There are multiple exceptions that can occur during loading the system
state from toml files. Now they are caught and wrapped in StateLoadError.