libdnf5 IPlugin: Use pImpl

rpm-software-management · Apr 17, 2024 · d94d641 · d94d641
1 parent a7ab253
commit d94d641
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 3 deletions.
diff --git a/include/libdnf5/plugin/iplugin.hpp b/include/libdnf5/plugin/iplugin.hpp
@@ -20,6 +20,7 @@ along with libdnf.  If not, see <https://www.gnu.org/licenses/>.
 #ifndef LIBDNF5_PLUGIN_IPLUGIN_HPP
 #define LIBDNF5_PLUGIN_IPLUGIN_HPP
 
+#include "libdnf5/common/impl_ptr.hpp"
 #include "libdnf5/version.hpp"
 
 #include <cstdint>
@@ -123,7 +124,8 @@ class IPlugin {
     Base & get_base() noexcept;
 
 private:
-    Base * base;
+    class Impl;
+    ImplPtr<Impl> p_impl;
 };
 
 }  // namespace libdnf5::plugin

diff --git a/libdnf5/plugin/iplugin.cpp b/libdnf5/plugin/iplugin.cpp
@@ -21,7 +21,19 @@ along with libdnf.  If not, see <https://www.gnu.org/licenses/>.
 
 namespace libdnf5::plugin {
 
-IPlugin::IPlugin(Base & base) : base(&base) {}
+
+class IPlugin::Impl {
+public:
+    explicit Impl(Base & base) : base(&base) {}
+
+    Base & get_base() const noexcept { return *base; }
+
+private:
+    Base * base;
+};
+
+
+IPlugin::IPlugin(Base & base) : p_impl(new Impl(base)) {}
 
 IPlugin::~IPlugin() = default;
 
@@ -48,7 +60,7 @@ void IPlugin::post_transaction([[maybe_unused]] const libdnf5::base::Transaction
 void IPlugin::finish() noexcept {}
 
 Base & IPlugin::get_base() noexcept {
-    return *base;
+    return p_impl->get_base();
 }
 
 }  // namespace libdnf5::plugin