-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop collect file for ABRT #2101
Conversation
The patch is also related to #1986 and https://bugzilla.redhat.com/show_bug.cgi?id=2120960 |
This pull requests remove the dependency and removes the file. But it still installs the file in etc/CMakeLists.txt and packages it in %files data section. If you want to remove it, then remove it everywhere. Otherwise, I have submitted a PR#2092 which retains the file and fixes the packaging. I have no idea whether the file is still needed. |
It looks like that it is not required anymore Resolve: https://issues.redhat.com/browse/RHEL-40382
According to Michal Srb from ABRT it is not required anymore therefore I think we can remove it. The file was introduce 12 years ago. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now the removal is implemented correctly.
I doubt that ABRT will be able to report DNF logs after applying this patch. But that was their decision to remove libreport from ABRT so I'm going to merge this patch. The dnf-tests failure is unrelated: The test system is unable to install obsoleted yum package. |
It looks like that it is not required anymore
Resolve: https://issues.redhat.com/browse/RHEL-40382