-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
spec: Package Python examples #432
spec: Package Python examples #432
Conversation
Macro is available on Fedora 39 - tested by |
I found that macro in RHEL 9 and 8. I was unable to check RHEL 7. |
I think that this option is better then to replace The current code requires to have installed |
I use the macro because all packaged files needs to conform the packaging guidelines. /usr/bin/env as found in the sources does not conform and rpmlint correctly warns on it. Do you want me to add this explanation to the commit message? What do you mean with "python-unversioned-command"? I cannot see it anywhere in the sources, neither in the built https://kojipkgs.fedoraproject.org//packages/createrepo_c/1.1.2/1.fc41/x86_64/python3-createrepo_c-1.1.2-1.fc41.x86_64.rpm. What do you mean with "The current code requires [...] to make example functional"? Documentation files is exempted from adding RPM dependencies. |
Please may I ask you to add to commit message that the change is required by Fedora guidelines with a reference? My previous commend about |
%py3_shebang_fix macro corrects shebangs in the documentation files to make them conforming to Fedora packaging guidelines <https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_shebangs>.
601e83f
to
1b5f1a0
Compare
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
0520f0c
into
rpm-software-management:master
We already use it in F41 package. I'm only not sure since when %py3_shebang_fix is supported.